Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix format parameter mismatch #2237

Merged
merged 4 commits into from
Sep 12, 2015
Merged

Fix format parameter mismatch #2237

merged 4 commits into from
Sep 12, 2015

Conversation

rrosenblum
Copy link
Contributor

This fixes #2234.

I got started by fixing the issue with calling format on variables. I then found an edge case where calling Kernel.format or Kernel.sprintf instead of format or sprintf would cause false positives.

bbatsov added a commit that referenced this pull request Sep 12, 2015
@bbatsov
Merge pull request #2237 from rrosenblum/fix_format_parameter_mismatch
94be910 
Fix format parameter mismatch
@bbatsov bbatsov merged commit 94be910 into rubocop:master Sep 12, 2015
@bbatsov
Copy link
Collaborator

bbatsov commented Sep 12, 2015

👍

@rrosenblum rrosenblum deleted the fix_format_parameter_mismatch branch September 16, 2015 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False positive in Lint/FormatParameterMismatch when called on a variable
2 participants
@rrosenblum @bbatsov