Fix Style/TrivialAccessors to support AllowPredicates: false
#2014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gotrevor
force-pushed
the
TrivalPredicate_AllowPredicates_bugfix
branch
from
38d7e7f
to
0260d38
Compare
gotrevor
force-pushed
the
TrivalPredicate_AllowPredicates_bugfix
branch
from
0260d38
to
e771f4b
Compare
|
Hmm, I'm confused. I didn't even remember we had such option and I have no idea why it's the default. Guess the fact that it didn't work helped for this. I wonder if it's needed at all... |
|
I having the default as false is probably right. Later in that thread, looks like you merged in the changes in a separate commit. I don't have a strong opinion on whether this option should stay or go. I just noticed it because, in master, |
bbatsov
added a commit
that referenced
this pull request
Jul 5, 2015
…s_bugfix Fix `Style/TrivialAccessors` to support AllowPredicates: false
|
OK, fair enough. I guess I'll dwell on this more some other time and I should definitely work on the config documentation. Thanks for spotting and fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.