don't count disabled offences if fail-level is autocorrect #1978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The fix looks good, but you'll have to rebase. Good remark about the huge spec. //cc @jonas054 |
fix rubocop offense, add CHANGELOG entry
bbatsov
added a commit
that referenced
this pull request
Jun 19, 2015
don't count disabled offences if fail-level is autocorrect
|
👍 |
|
👍 I agree about splitting etc. Don't know in detail where to place each spec example, but if someone would start an effort to achieve a more visible structure, they'd have my support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stumbled across this case because we always use fail-level autocorrect and noticed that the wrong error-code is returned for files with disabled offences. This minor change should fix that.
there is probably a better place to put that spec but I have no idea how that >3000 lines spec file is structured (maybe it would be a good idea to somehow split that file for easier navigation)