Correct whitespace braces around hash parameters #1315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end | ||
|
|
||
| it 'one hash parameter with braces and separators' do | ||
| corrected = autocorrect_source(cop, ['where( ', | ||
| ' { x: 1 } )']) | ||
| ' { x: 1 } )']) |
There was a problem hiding this comment.
Why the extra space here?
There was a problem hiding this comment.
right, no good reason for that.
There was a problem hiding this comment.
Well actually, it tests that ALL whitespace between the { and the start of its contents is removed, not just ONE space.
There was a problem hiding this comment.
I think there should a separate example for this to make it more apparent that this behavior is being tested.
|
You should also update the changelog. |
|
Updated changelog and added tests. |
|
Apart from my changelog entry remark - looks good. Update the changelog and squash the commits into one. |
|
Changelog entry moved to 'bugs fixed' section and squashed commits into one. |
bbatsov
added a commit
that referenced
this pull request
Aug 31, 2014
…aces-around-hash-parameters Correct whitespace braces around hash parameters
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.