Add auto-correct to BlockAlignment cop

[barunio]

This is a modified version of #1002. The original PR went beyond the scope of this one cop, so this no longer includes the extra functionality. (That will be taken care of by a new cop, which I'll open a PR for in a bit.)

Note that the class disables the ClassLength cop, because it is too long with the extra functionality. It didn't make sense to me to extract the autocorrect into a module, since it isn't shared anywhere, just to satisfy the length limit. Let me know if there's some other approach that you think makes more sense here.

[bbatsov]

Looks OK to me, but let's here what @jonas054 thinks as well. You should also add a changelog entry for this.

[jonas054]

@barunio The AutocorrectAlignment module has most of the funtionality you need. All but the "end statement is not on its own line" part. I wonder if you could find a way to use AutocorrectAlignment, adding the missing ingredient to that module. It could perhaps solve the class length problem.

[jonas054]

Or actually a new cop for "end statement is not on its own line" similar to the one in #1079 makes much more sense. Then you can use AutocorrectAlignment without changes.

[bbatsov]

@barunio Ping

[bbatsov]

@jonas054 Would you look into wrapping this PR and #1079? Seems that @barunio is MIA and I don't like keeping PRs opened for months.

[jonas054]

Sure.

[barunio]

@bbatsov @jonas054 Ah, apologies! I've just been swamped, so I lost track of this entirely. As this PR was my responsibility, I'm happy to re-examine it today and adjust for the above comments. I think I have another PR open that also needs to be closed out.

[jonas054]

Thanks, @barunio. I'll hold my horses.

[bbatsov]

It'd be good if this were wrapped soon, as I plan to release the next stable version in the beginning of next week.

[barunio]

ok, will try to wrap it up today

[coveralls]

Coverage increased (+0.0%) when pulling 9d052f4beb6df86a1fe01943500281e9c74cec3c on barunio:block_alignment_autocorrect into 106da8b on bbatsov:master.

[barunio]

@jonas054 @bbatsov

I split up the "end statement not on its own line" into a separate cop as requested. But, I don't see any easy way to use the AutocorrectAlignment module for the other changes, since that module is designed to align all lines in the node, whereas I just want to align the last line with the first. If one of you wants to edit further to change that, feel free. I won't have time to make further changes.

I'm not sure if BlockEndNewline is the best name for the new cop; let me know if you prefer something different.

[coveralls]

Coverage increased (+0.0%) when pulling fcf8548 on barunio:block_alignment_autocorrect into 106da8b on bbatsov:master.

[bbatsov]

Guess this will do for now. Thanks!