Non Nil in boolean methods

[geniou]

In my opinion a method with a ? at the end should return a boolean value, but if I write code like

def signed_in?
  !current_user.nil?
end

or

def signed_in?
  !!current_user
end

I get a message from rubocop. I know, that

def signed_in?
  current_user
end

should work as well, but I would expect the return of this method to be a boolean - not an user object.

Is there an idea, without disabling this cop?

[bbatsov]

Such distinction seems irrelevant to me. The check can be refined, of course, as this would mostly resolve the only actual problem with it (which we discussed with @yujinakayama yesterday):

def value_set?
  !@some_boolean.nil?
end

[geniou]

Sorry - I got a mistake in my first example.. I fixed it.

[fabiopelosin]

I share @geniou views.

[bbatsov]

Done.

[fabiopelosin]

💙

[geniou]

thanks