Fix SpaceBeforeFirstArg cop for multiline arguments

[cschramm]

I have this code:

SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
    SimpleCov::Formatter::HTMLFormatter,
    SimpleCov::Formatter::RcovFormatter
]

The cop treats everything after the equal sign as arg1_with_space and this does in fact start with a space, but the regular expression searches for any line not starting with a whitespace, not just the first one.

[jonas054]

Yep, you found a bug. My bad.

Code looks good, @cschramm! Please add a spec example that fails before your fix, and an entry in CHANGELOG.md as well.

[jonas054]

Actually, I might have been too quick when endorsing the change. This cop, which is a lint cop, should not warn for setter calls without leading space (a.b=c). That's a different concern that's already handled by SpaceAroundOperators.

So changing the regexp is good. We should keep that. But we also need examples saying that setter calls without space are accepted by this cop, and that a first argument that is preceded by a space and contains a non-space right after a line break within it, is accepted.

We usually exclude setter calls by return if method_name.to_s.end_with?('=').

[bbatsov]

@jonas054 Won't it be simpler if we checked whether the method name ends with ! or ?. Are there any other cases that need handling?

[jonas054]

There's one more that is not in any big need of handling, but I though could tag along, and that's

method"some string"

I can't think of any others. Well, there's

puts`ls`

[bbatsov]

@jonas054 I think those are all the cases that need handling, indeed. @cschramm, will you make the required changes or should we do them ourselves?

[cschramm]

I can do so. Do you want to blacklist !, ?, " and ` or just whitelist =?

[bbatsov]

Whilelist assignment.

[cschramm]

Done.

[bbatsov]

@cschramm you'll have to squash and rebase on top of the current master. Looks good to me, otherwise.

@jonas054 Are you happy with the current state of the code?

[bbatsov]

You can make this a bit more readable like this:

inspect_source(cop, ['something [',
                                  '  foo',
                                  '  bar',
                                  ']'])

[cschramm]

Squashed and rebased.

[jonas054]

👍 I'm happy with the changes.

[bbatsov]

Thanks!

[cschramm]

You're welcome 😃