Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MaxSlashes of -1 produced #879

Closed
agrimm opened this issue Mar 13, 2014 · 2 comments
Closed

MaxSlashes of -1 produced #879

agrimm opened this issue Mar 13, 2014 · 2 comments
Assignees
@jonas054

Comments

@agrimm
Copy link
Contributor

agrimm commented Mar 13, 2014

Running rubocop auto-gen-config produces

RegexpLiteral:
  MaxSlashes: -1

If this is used, then it complains

Illegal value for MaxSlashes: -1
@bbatsov
Copy link
Collaborator

bbatsov commented Mar 14, 2014

Seems like a remnant from a change @jonas054 had originally envisioned. @jonas054 Would you, please, take care of this?

@jonas054 jonas054 self-assigned this Mar 14, 2014
@jonas054
Copy link
Collaborator

@bbatsov That's right. The bug is actually visible in the specs if one looks closely. We expect to generate -1 and we expect -1 to fail. I'll fix it so we generate Enabled: false instead of negative MaxSlashes.

bbatsov added a commit that referenced this issue Mar 14, 2014
@bbatsov
Merge pull request #882 from jonas054/fix_max_slashes
522f134 
[Fix #879] Do not generate RegexpLiteral: MaxSlashes: -1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonas054 jonas054

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@agrimm @bbatsov @jonas054