Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"spans more than one line" error when using --auto-correct #790

Closed
nickserv opened this issue Feb 3, 2014 · 2 comments
Closed

"spans more than one line" error when using --auto-correct #790

nickserv opened this issue Feb 3, 2014 · 2 comments
Assignees
@jonas054
Labels
bug

Comments

@nickserv
Copy link

nickserv commented Feb 3, 2014

Results

Rubocop corrects part of the code, but crashes with this file. I am not sure which line of my code is causing this issue, if any.

Inspecting 16 files
CC#<Parser::Source::Range /home/nick/Repos/magician/lib/magician/math.rb 5141...5723> spans more than one line

Steps to reproduce

git clone https://github.com/thenickperson/magician
cd magician
git checkout 5f1edf3
rubocop --auto-correct

Rubocop version

0.17.0 (using Parser 2.1.4, running on ruby 2.1.0 i686-linux)
@jonas054 jonas054 added the bug label Feb 3, 2014
@jonas054
Copy link
Collaborator

jonas054 commented Feb 3, 2014

Yes, that's a bug, alright. Also present in latest master. I'll see if I can fix it.

@jonas054 jonas054 self-assigned this Feb 3, 2014
bbatsov added a commit that referenced this issue Feb 3, 2014
@bbatsov
Merge pull request #792 from jonas054/fix_autocorrect_interference
3a831e6 
[Fix #790] Make smaller replace in MethodDefParentheses autocorrect
@nickserv
Copy link
Author

nickserv commented Feb 4, 2014

This is now fixed in master. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonas054 jonas054

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonas054 @nickserv