-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix alignment of the hash in one line #514
Conversation
Good catch @saks! I was just thinking that if any two keys are on the same line, that we should just |
@jonas054 I think your suggestion is a good one. |
Completely agree 👍 |
@saks You should also mention the bugfix in the changelog. |
@saks Ping :-) |
Sorry for the delay, was really hard week. |
@saks Looks good, but you'll need to rebase on top of the current |
I did a rebase from current master. Is it ok now? |
I guess something is wrong. :) I suggest the following steps to construct proper commit graph in the current state: $ git checkout master
$ git branch -m fix_for_one_line_hash fix_for_one_line_hash.bak
$ git checkout -b fix_for_one_line_hash
$ git cherry-pick 4a8ee1b
error: could not apply 4a8ee1b... Fix alignment of the hashe containing different key lengths
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'
# Fix the conflict...
# ...
$ git add .
$ git commit
$ git push -f your-remote-name fix_for_one_line_hash |
Conflicts: spec/rubocop/cop/style/align_hash_spec.rb
You're right. Thanks. How about this? :) |
Fix alignment of the hash in one line
Yep, it's OK now. |
Thanks |
This fixes incorrect behavior in the case, when hash is written in one line with different length of keys.