cop ColonMethodCall shouldn't forbid constructor like calls

[markijbema]

Ruby has the tradition of adding constructor-like methods to instantiate classes, for instance Array() to construct an instance of Array. Some libraries offer this as well, like Nokogiri. Their readme suggests using colons, and I do think it makes sense in this case, and should be excepted from the ColonMethodCall:

doc = Nokogiri::HTML(open('http://www.google.com/search?q=sparklemotion'))

Opinions?

My suggestion would be to allow method calls which start with a capital letter.

[bbatsov]

:: will probably be removed from Ruby in 3.0 (not sure if Nokogiri's maintainers are aware of this). I generally dislike this style, since some people are initially confused that they are dealing with a class instead of method call, but I'm ok to have this as an option of the cop, disabled by default.

[markijbema]

That's not how I would interpret it:

http://blade.nagaokaut.ac.jp/cgi-bin/scat.rb/ruby/ruby-core/54883

Matz is saying it's not happening before 3.0 at least, but the argument he makes against deprecation is specifically about the exception I'm adding support for here. I'm not against making it optional, but I think it's here to stay.

[bbatsov]

Can't argue with that, no option needed :-) I guess you should update the relevant section of the style guide as well.