Add new Rails/RelativeDateConstant cop
#4003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bbatsov
reviewed
Feb 3, 2017
| module RuboCop | ||
| module Cop | ||
| module Rails | ||
| # This cop checks whether constant are relative date. |
There was a problem hiding this comment.
The description of cop should be extended here.
bbatsov
reviewed
Feb 3, 2017
| # end | ||
| # end | ||
| class RelativeDateConstant < Cop | ||
| MSG = 'Do not use `%s` in constant variable, because they ' \ |
There was a problem hiding this comment.
Do not assign %s to constants as it will be evaluated only once.
bbatsov
reviewed
Feb 3, 2017
| MSG = 'Do not use `%s` in constant variable, because they ' \ | ||
| 'are evaluated only once at system running.'.freeze | ||
|
|
||
| BAD_METHODS = %i(ago from_now since until).freeze |
bbatsov
reviewed
Feb 3, 2017
| end | ||
| end | ||
|
|
||
| def bad_method_without_args?(node) |
There was a problem hiding this comment.
same here
I'd drop without_args from the name of the method
|
Looks OK to me apart from my small remarks. I guess it can even have auto-correct. |
|
Thanks for review comments. I fixed it. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We probably do not use relative date from system startup time as constant. This cop checks it.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
rake generate_cops_documentation(required only when you've added a new cop or changed the configuration/documentation of an existing cop).