Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EmptyLineBetweenDefs complaining when it shouldn't #400

Closed
solnic opened this issue Jul 29, 2013 · 2 comments · Fixed by #404
Closed

EmptyLineBetweenDefs complaining when it shouldn't #400

solnic opened this issue Jul 29, 2013 · 2 comments · Fixed by #404
Assignees
Labels

Comments

@solnic
Copy link

solnic commented Jul 29, 2013

So, I have this:

module SpecHelper

  def mock_model(*attributes)
    Class.new {
      include Equalizer.new(*attributes)

      attributes.each { |attribute| attr_accessor attribute }

      def initialize(attrs)
        attrs.each { |name, value| send("#{name}=", value) }
      end
    }
  end

end

and the EmptyLineBetweenDefs complains here which is not correct, I suppose.

@ghost ghost assigned jonas054 Jul 30, 2013
@jonas054
Copy link
Collaborator

But the style guide says "Use empty lines between defs", so I still think it's a bug. I'll take a look at the problem.

@solnic
Copy link
Author

solnic commented Jul 30, 2013

oh wow that was fast @jonas054 😄 thanks guys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants