Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill the rule suggesting the use of specific reduce block argument names #3725

Closed
vitormd opened this issue Nov 17, 2016 · 1 comment
Closed

Comments

@vitormd
Copy link

vitormd commented Nov 17, 2016

I was about to complain about the rule suggesting the use of |a, e| as block params name for reduce and so I went to the style-guide used by rubocop and the last commit is this one:
commit.

Bottom line:

  • A user should be allowed to choose other names for reduce block params. Such as
total_jobs = jobs.reduce { |sum, job| sum + job.count }

I am happy to come here create this issue so it gets updated immediately.

@bbatsov
Copy link
Collaborator

bbatsov commented Nov 22, 2016

The cop should not be killed (some people likely find it useful), but I guess we can disable it by default.

tejasbubane added a commit to tejasbubane/rubocop that referenced this issue Dec 1, 2016
pocke added a commit to pocke/rubocop that referenced this issue Jan 8, 2017
`Style/SingleLineBlockParams` cop was supposed to be disabled in rubocop#3755 .
However, it seems to be enabled.

I fixed it.
bbatsov pushed a commit that referenced this issue Jan 8, 2017
`Style/SingleLineBlockParams` cop was supposed to be disabled in #3755 .
However, it seems to be enabled.

I fixed it.
backus added a commit to backus/rubocop that referenced this issue Jan 8, 2017
Intended to help avoid issues like @pocke fixed in rubocop#3725
bbatsov pushed a commit that referenced this issue Jan 9, 2017
Intended to help avoid issues like @pocke fixed in #3725
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants