Change misleading message of Style/EmptyLinesAroundAccessModifier:

[ShockwaveNN]

If we have file test.rb with code:

module A
  private
  def a
  end
end

rubocop show warning: test.rb:2:3: C: Keep a blank line before and after private.
Ok, manually add blank line before and after private:

module A

  private

  def a
  end
end

No good: test.rb:2:1: C: Extra empty line detected at module body beginning.

Accroding to #3480 (comment) - best way is to make two different messages for both cases.

RuboCop version

$ rubocop -V
0.42.0 (using Parser 2.3.1.2, running on ruby 2.1.10 x86_64-linux)

[bquorning]

I was gonna point out that Style/EmptyLinesAroundModuleBody can be configured with EnforcedStyle: empty_lines, in which case the existing message “Keep a blank line before and after private” fits perfectly.

But that’s actually a bad argument, since EmptyLinesAroundModuleBody would complain about the missing blank line above private, while EmptyLinesAroundAccessModifier would complain about the missing blank line below:

test.rb:2:1: C: Style/EmptyLinesAroundModuleBody: Empty line missing at module body beginning.
  private
^
test.rb:2:3: C: Style/EmptyLinesAroundAccessModifier: Keep a blank line before and after private.
  private
  ^^^^^^^
test.rb:5:1: C: Style/EmptyLinesAroundModuleBody: Empty line missing at module body end.
end
^

[bquorning]

Suggested fix in #3527.