Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EndAlignment valid? #318

Closed
lenntt opened this issue Jul 1, 2013 · 2 comments
Closed

EndAlignment valid? #318

lenntt opened this issue Jul 1, 2013 · 2 comments

Comments

@lenntt
Copy link

lenntt commented Jul 1, 2013

Hi, (its me again)

I get an EndAlignment offence for the following lines of code.
Rubocop wants me to allign the end with {{value.all?}}.
Is this intentioned? (cant say I like it)
If so, we might need to make this more explicit in the ruby-style-guide I think?

#rubocop disapproves:
(value.is_a? Array) && value.all? do |subvalue|
    type_check_value(subvalue, array_type)
end
#rubocop accepts:
(value.is_a? Array) && value.all? do |subvalue|
                         type_check_value(subvalue, array_type)
                       end
@jonas054
Copy link
Collaborator

jonas054 commented Jul 1, 2013

No I think that's a bug. I've noticed this too so I'm already working on a solution.

@bbatsov
Copy link
Collaborator

bbatsov commented Jul 1, 2013

That's definitely a bug. I guess @jonas054 is on top of it and will have it fixed soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants