-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cache or --cache option #1924
Comments
I think it could be useful, I have an implementation of a |
I am curious to see an implementation of this. I am currently struggling to see how this would differ from specifying an output file that can be reviewed later. I too use RuboCop on a large project, one that takes RuboCop about 7 minutes to process. We set up a rake task to run RuboCop against unpushed or unmerged files locally, and then have jenkins run RuboCop against the entire codebase. This works well for day to day work when you aren't enabling new cops. I would be happy to share this configuration if anyone is interested. |
Alright @rrosenblum, it's not ready but you can take a look here: https://github.com/bbatsov/rubocop/compare/master...jonas054:cache_option?expand=1 I think the difference between saving the result of a whole run and caching results is, that when you change one file in the inspected code base, you have to run for 7 minutes to produce the output file again, whereas with a |
Looks interesting. It sounds like it could be a better solution than my current solution of running against unpushed/unmerged files. |
I run |
[Fix #1924] Use a cache to speed things up
Hi!
Not sure if it would be worth it, it probably is a lot of work.
Could there be a --cache option added, or similar?
Sometimes I run rubocop on a large codebase, and it takes a while - not so long, perhaps 1 minute.
With a --cache option, we could also store the information in the HOME DIRECTORY of the user, with the name of the directory in question.
That way, we could simply re-read that cache on later tries again.
Reason: I just ran rubocop on a codebase, then went to focus on my editor and fixed some issues. Made a break, came back later when I did other things.
I use kde konsole with several tabs though - I thought that it might be useful to have a --cache option to review what I used rubocop some hours ago.
If this is not useful feel free to close the issue. :)
Thanks.
The text was updated successfully, but these errors were encountered: