Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class definition is too long, but it is not! #1851

Closed
lustremedia opened this issue Apr 30, 2015 · 4 comments
Closed

Class definition is too long, but it is not! #1851

lustremedia opened this issue Apr 30, 2015 · 4 comments

Comments

@lustremedia
Copy link

False positive error

json_data_service.rb:4:1: C: Class definition is too long. [106/100]
class JsonDataService
^^^^^

Class definition

include ServiceHelper

class JsonDataService
  attr_reader :base_url
  ....
@jonas054
Copy link
Collaborator

There's not enough information here. You have to show the entire class, otherwise there's no way to work on the problem.

@lustremedia
Copy link
Author

What does Rubocop actually say here? afaik it says that class JsonDataService is 106 Chars long and should be <= 100, no?

@jonas054
Copy link
Collaborator

jonas054 commented May 1, 2015

No, it's about lines -- how long the implementation is, from class to end.

@lustremedia
Copy link
Author

Ah ok! Well then I guess it is not a bug!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants