Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with AutoCorrect configuration parameter #1834

Closed
jonas054 opened this issue Apr 25, 2015 · 1 comment
Closed

Problems with AutoCorrect configuration parameter #1834

jonas054 opened this issue Apr 25, 2015 · 1 comment

Comments

@jonas054
Copy link
Collaborator

A generic AutoCorrect configuration parameter that can be used in for any cop was introduced in #1657. It has two shortcomings:

  1. It needs to be configured like this
CopName:
  AutoCorrect: "False"

So neither False nor false will work, which is counter-intuitive for this parameter.
2. When the parameter is added in .rubocop.yml, RuboCop prints a warning, e.g.:

Warning: unrecognized parameter Style/StringLiterals:AutoCorrect found in /home/jonas/dev/rubocop/.rubocop.yml
jonas054 added a commit to jonas054/rubocop that referenced this issue Apr 25, 2015
Allow boolean false as value, besides string "False". Ensure
no warning is printed when the AutoCorrect parameter is used.
@rrosenblum
Copy link
Contributor

I saw the issue with the string false earlier and I hadn't gotten a chance to write up the issue yet. I am glad to see that someone else found it as well.

bbatsov added a commit that referenced this issue Apr 26, 2015
[Fix #1834] Improve the AutoCorrect config parameter handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants