TrailingComma got strict_comma
#1621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bbatsov this is green now |
|
I've been pretty busy at work lately. I'll try to review the PR over the weekend. |
|
@bbatsov ping |
| @@ -511,6 +511,7 @@ Style/TrailingComma: | |||
| EnforcedStyleForMultiline: no_comma | |||
| SupportedStyles: | |||
| - comma | |||
| - strict_comma | |||
There was a problem hiding this comment.
This will have to be explained in the preceding comment. I'm also not sure about this name.
There was a problem hiding this comment.
how about consistent_comma?
|
Overall the code looks good to me. Any feedback from anyone else? |
|
@bbatsov addressed your comments |
|
You forgot to update the commit message. |
Any element with a line break in its declaration is now considered to be multiline, which results in more consistent behaviour for this cop.
|
@bbatsov fixed |
bbatsov
added a commit
that referenced
this pull request
Feb 24, 2015
`TrailingComma` got `consistent_comma`
|
👍 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any element with a line break in its declaration is now considered to
be multiline, which results in more consistent behaviour for this cop.