Japanese Windows user may see encoding trouble with --format html

[scivola]

rubocop --format html

causes

incompatible character encodings: Windows-31J and UTF-8
(erb):179:in `concat'
(erb):179:in `block (2 levels) in binding'
(erb):171:in `each'
(erb):171:in `block in binding'
(erb):166:in `each'
(erb):166:in `binding'

because

     template = File.read(TEMPLATE_PATH)

does not specify any encoding explicitly.

Solution:

--- lib/rubocop/formatter/html_formatter.rb
+++ lib/rubocop/formatter/html_formatter+.rb
@@ -38,7 +38,7 @@
       def render_html
         context = ERBContext.new(files, summary)

-        template = File.read(TEMPLATE_PATH)
+        template = File.read(TEMPLATE_PATH, encoding: Encoding::UTF_8)
         erb = ERB.new(template, nil, '-')
         html = erb.result(context.binding)

rubocop -V
0.28.0 (using Parser 2.2.0.2, running on ruby 2.1.5 i386-mingw32)

[bbatsov]

Your solution looks good to me. @jonas054 @yujinakayama Do you agree?

[bbatsov]

@scivola Guess you can open a PR.

[jonas054]

If that works for you @scivola I think it's correct.