Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style/MultilineOperationIndentation doesn't catch lines ending in \ #1473

Closed
mockdeep opened this issue Dec 4, 2014 · 5 comments
Closed
Assignees

Comments

@mockdeep
Copy link
Contributor

mockdeep commented Dec 4, 2014

When I wrap strings with \ the MultilineOperationIndentation style check doesn't flag them when they are misindented. The following string passes checks:

      flash[:error] = 'Here is a string ' \
                      'That spans' <<
        'multiple lines'

Side note, it also allows << for multi-line strings. I'll add another issue for that.

@mockdeep
Copy link
Contributor Author

mockdeep commented Dec 4, 2014

Additionally, I'm using the rule with EnforcedStyle: indented.

@mockdeep
Copy link
Contributor Author

mockdeep commented Dec 4, 2014

Another side note, when I change the \ to a + it fails both checks.

@bbatsov
Copy link
Collaborator

bbatsov commented Dec 9, 2014

@jonas054 Likely the same problem as in #1474 (the concatenated string is a dstr node without beg/end).

@jonas054
Copy link
Collaborator

jonas054 commented Dec 9, 2014

It certainly looks like it. I'll try to fix it.

@jonas054 jonas054 self-assigned this Dec 9, 2014
@jonas054
Copy link
Collaborator

It turned out to be a different problem.

bbatsov added a commit that referenced this issue Dec 10, 2014
…tion_bug

[Fix #1473] Recognize operator []= in MultilineOperationIndentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants