Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opal, Rails asset preprocessor and Style/LeadingCommentSpace #1445

Closed
lloeki opened this issue Nov 12, 2014 · 1 comment
Closed

Opal, Rails asset preprocessor and Style/LeadingCommentSpace #1445

lloeki opened this issue Nov 12, 2014 · 1 comment

Comments

@lloeki
Copy link
Contributor

lloeki commented Nov 12, 2014

Rails (or is that Sprockets?) asset pipeline uses a comment sign followed by = (hence #= in our case) in the first comment block of a file to include preprocessor directives in asset files. This conflicts with Rubocop in Opal files, making the following workaround mandatory:

# rubocop:disable Style/LeadingCommentSpace
#= require_tree ../templates/bootstrap
# rubocop:enable Style/LeadingCommentSpace

Could it be possible to make Style/LeadingCommentSpace smarter?

@bbatsov
Copy link
Collaborator

bbatsov commented Dec 9, 2014

We can allow #= I guess. Not sure if there are better/smarter alternatives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants