Auto correcting substitues a rescued Exception with a blind rescue

[rousisk]

I completely agree with avoiding rescuing the Exception class but I think that auto correcting this:

rescue Exception => e

to

rescue => e

might be an issue, as the two are not equivalent (and in a not so obvious way for that matter).

Personally, when I use the auto correct feature (mostly for older projects) I am under the assumption that there won't be any behavioural changes and ideally nothing will break.

What do you think on that?

[bbatsov]

Hmm, that's a bug. rescue => e is equivalent to rescue StandardError => e.

[bbatsov]

On second thought - it's not. The idea is we want to replace the Exception with StandardError. While this is not equivalent it's unlikely to cause problems in practice.

[mikegee]

@rousisk Lint/RescueException is the applicable cop. You will want to disable it in your .robocop.yml or with a source comment.

[rousisk]

Thanks @mikegee, it's not a big issue anymore. I was just auto-correcting an existing, large, project and I started seeing test failures due to this substitution. That's the reason I perceived it as surprising or "not so safe". But totally agree with the underlying principle.

[bbatsov]

This issue is related to #950. Ideally, the cop won't do auto-corrections by default unless non-equivalent corrections are allowed.