SpaceInsideParens style checker does not recognize space after parens in some conditions

[joshchu]

Test case to reproduce:

  it 'reproduces issue that SpaceInsideParens does not catch space on LHS parens' do
    inspect_source(cop, ['test = ( 4 * 60 * 60)'])
    expect(cop.messages).not_to be_empty
  end

I suspect there's some sort of parse issue with SurroundingSpace but haven't had a chance to investigate/debug further

[jonas054]

Thanks for reporting, I'll take a look.

[joshchu]

Awesome thanks @jonas054 . It might be something with order of operations and a conflict with ParenthesesAsGroupedExpression?

[jonas054]

No, it's just that different kinds of left parentheses (method call, expression grouping) are represented by different tokens. We only support one currently.

[joshchu]

Awesome thanks for the quick response @jonas054!