Check indentation of method arguments spanning multiple lines

[bquorning]

Rubocop with default configuration detects no offenses on this code:

def run(first, second = {})
  puts "#{first} #{second}"
end

def defaults
  { a: 1 }
end

run(:foo, defaults.merge(
   bar: 3
  )
 )

run(
   :foo,
   bar: 3
 )

I do, however. All of the arguments to the #run calls are mis-indented.

[bbatsov]

@jonas054 Would you look into this?

[jonas054]

Sure. @bbatsov @bquorning What do you think the correct indentation should be? Some example code please.

[bbatsov]

Perhaps:

run(:foo, defaults.merge(
            bar: 3
          )
   )

run(
  :foo,
  bar: 3
)

[bbatsov]

Not sure, about the first case, but I'm pretty sure about the second one.

[bquorning]

There’s no doubt about the second example – I would indent it as @bbatsov does:

run(
  :foo,
  bar: 3
)

The first one is more tricky. I definitely don’t like the “hanging indentation” of the hash and closing parentheses. The problem is that two parentheses are opened on the same line, but closed on different lines.

They should either be closed on the same line

run(:foo, defaults.merge(
  bar: 3
))

Or opened on different lines:

run(:foo,
  defaults.merge(
    bar: 3
  )
)

Or one or both sets of parentheses just be on the same line:

run(:foo,
  defaults.merge(bar: 3)
)

run(:foo, defaults.merge(bar: 3))

Keeping both opening parentheses on one line and closing them on different lines, I cannot think of a style that looks pleasant:

run(:foo, defaults.merge(
    bar: 3
  )
) # Nope

run(:foo, defaults.merge(
            bar: 3
          )
) # Nope

run(:foo, defaults.merge(
            bar: 3
          )
   ) # Nope

[jfelchner]

Where the arguments are placed should be the focus of one cop and how the closing parens are placed should probably be the focus of a separate cop no?

[jonas054]

@jfelchner Yes! Because they follow different rules.

[bquorning]

Great work on the FirstParameterIndentation cop.

Would it be possible to check the ending parentheses, too? RuboCop still reports no offenses for this code:

def foo
  puts('x'
                            )
end

def bar
  puts(
    'y'
                            )
end

[bbatsov]

It's possible, but it should be done by a dedicated cop IMO.

On 23 February 2015 at 14:57, Benjamin Quorning [email protected]
wrote:

Great work on the FirstParameterIndentation cop.

Would it be possible to check the ending parentheses, too? RuboCop still
reports no offenses for this code:

def foo
puts('x'
)end
def bar
puts(
'y'
)end

—
Reply to this email directly or view it on GitHub
#1144 (comment).

Best Regards,
Bozhidar Batsov

http://www.batsov.com