IndentationConsistency & IndentationWidth auto-correct combined breaks code

[andreaseger]

another bug found in out huge and old codebase.

Before:

module Bar
class Goo
  def something
    first call
      do_other 'things'
      if other > 34
        more_work
      end
  end
end
end

After rubocop --only IndentationConsistency,IndentationWidth --auto-correct indentation_minimal_bug1.rb

module Bar
  class Goo
    def something
      first call
      do_other 'things'
      if other > 3  4
      more_wor  k
    end
    end
  end
end

If I run each of these cops separately one after the other it works as expected and generated the following:

module Bar
  class Goo
    def something
      first call
      do_other 'things'
      if other > 34
        more_work
      end
    end
  end
end

[bbatsov]

Sounds like another task for @jonas054 :-)

[andreaseger]

I found an other one which I think is related to this one. This time its AlignArray + IndentationWidth

before:

module Foo
class Bar

  stuff = [
            {
              some: 'hash',
            },
                 {
              another: 'hash',
              with: 'more'
            },
          ]
end
end

after rubocop --only AlignArray,IndentationWidth --auto-correct indentation_minimal_bug2.rb

module Foo
  class Bar

    stuff = [
              {
                some: 'hash',
              },
              {
       another: 'ha  sh',
       with: 'm  ore'
     },
            ]
  end
end

This example does not break ruby syntax but just look at the strings it changed. Also note that the overall indentation is worse than before and an other run with all default cops on auto-correct does not really help