GuardClause cop for loops

[geniou]

What do you think about a cop that that checks for something similar to a guard clause but in loops. So something like this:

bad

foos.each do |foo|
 if foo['bar']
  # do something
 end
end

good

foos.each do |foo|
 next unless foo['bar']
 # do something
end

What do you think and how should this be called?

[geniou]

maybe it could be called PreferNext..

[jdickey]

I like it. That's something we keep forgetting to fix all over the place, and the next guard clause is much more readable. I'd also go for the name PreferNext.

Question: How should it deal with more pathological cases, like

foos.each do |foo|
  if foo['bar'] then
    # do *n* lines of something
  else
    if foo['quux'] then
      # do *m* lines of something else
    else
      # more bloviation here
    end
  end
end

I'd argue that the appropriate response would be to send a WTF email to everybody on the team; as a more practical workaround, should this new cop (or another related new cop) read this guy the riot act?

Come to think of it, this would be more appropriate as a different cop, yes? Something like MethodEnvy, since the example above really wants to be broken out into three support methods...

[geniou]

I think this cop should only take action if there is a single if at the end without any else. As you pointed out there could be an other cop, that takes care of such a logical mess.