Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ts_library source mapped files are now read only instead of symlinks to the source file #854

Closed
Toxicable opened this issue Nov 13, 2018 · 3 comments

Comments

@Toxicable
Copy link

When debugging a nodejs application via the VS Code debugger, when you hit a breakpoint, the debugger will take you to a readonly source mapped file.
This is terribly un ergonomic since you must then manually navigate to the source file before you can make any changes.

I believe this now superseeds bazelbuild/rules_typescript#254

This only started happening from the upgrade of rules_typescript=0.10.1 to current.
While the old issue of having source maps point to a symlinked file was also a unergonomic way to handle it, this is even worse and a blocker for us upgrading.
The ideal situation would be for source maps to point back to the source file

@Toxicable
Copy link
Author

The cause of this issue is actaully when preserve_symlinks=False is set in node_repositories.

@Toxicable
Copy link
Author

Toxicable commented Dec 22, 2018

The latest update in rules_typescript from 0.21.0 -> 0.22.0 have broken the above work around.
This commit here: bazelbuild/rules_typescript@676567c
I have a repo of it broken here: https://github.com/Toxicable/bug-bazel_source_maps

cc @vikerman

@alexeagle alexeagle transferred this issue from bazelbuild/rules_typescript Jun 12, 2019
@Toxicable
Copy link
Author

superseeded by #823

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants