From 0cbaf66b8d5dd751085dc68cef1518bab382791e Mon Sep 17 00:00:00 2001 From: lucassloan Date: Mon, 12 Aug 2019 15:50:28 -0700 Subject: [PATCH] Make libraries that depend on //javascript/angular2/testing/catalyst into ng_modules. Currently you need a dep on something in //third_party/javascript/angular2, so people are forced to insert dummy taze comments. PiperOrigin-RevId: 263022649 --- ts_auto_deps/updater/updater.go | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/ts_auto_deps/updater/updater.go b/ts_auto_deps/updater/updater.go index ff3d9868..b77acbad 100644 --- a/ts_auto_deps/updater/updater.go +++ b/ts_auto_deps/updater/updater.go @@ -958,13 +958,7 @@ func hasAngularDependency(r *build.Rule) bool { for _, li := range edit.AllLists(e) { for _, elem := range li.List { str, ok := elem.(*build.StringExpr) - if !ok { - continue - } - if strings.HasPrefix(str.Value, "//third_party/javascript/angular2") { - return true - } - if str.Value == "//javascript/angular2/testing/catalyst" { + if ok && strings.HasPrefix(str.Value, "//third_party/javascript/angular2") { return true } }