Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create migration guide for rules_swift 2.x #1230

Open
luispadron opened this issue Jun 19, 2024 · 6 comments
Open

Create migration guide for rules_swift 2.x #1230

luispadron opened this issue Jun 19, 2024 · 6 comments
Labels
type: feature request New feature or request

Comments

@luispadron
Copy link
Contributor

rules_swift 2.x (soon to be released) will be a major version with a few breaking changes. We should document the breaking changes and offer guidance on going from 1.x to 2.x for users and rule authors.

@luispadron luispadron added the type: feature request New feature or request label Jun 19, 2024
@luispadron
Copy link
Contributor Author

Some things I can think of we should go over:

  • Removal of swift.emit_symbol_graph feature, we should point users to the new swift_symbol_graph_extract rule.
  • Changes to C/C++/Objective-C module name determination, we should point users to the new swift_interop_hint rule and use of aspect_hints.

@brentleyjones
Copy link
Collaborator

Removal of the deprecated grpc/proto rules.

@brentleyjones
Copy link
Collaborator

I'm going to cherry-pick 57cdd76, so we should tell people to use the new load statements (though not a breaking change yet, the old way will only be deprecated for now).

@aaronsky
Copy link

aaronsky commented Jun 19, 2024

Removal of swift_c_module as the rule is redundant with swift_interop_hint's featureset

@brentleyjones
Copy link
Collaborator

swift.disable_system_index is now enabled by default

@brentleyjones
Copy link
Collaborator

Removed swift.bundled_xctests and swift.use_response_files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants