Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Zinc for dependency checking #1668

Open
jadenPete opened this issue Dec 9, 2024 · 0 comments
Open

Use Zinc for dependency checking #1668

jadenPete opened this issue Dec 9, 2024 · 0 comments

Comments

@jadenPete
Copy link

This issue is part of a broader proposal to merge some of the features in lucidsoftware/rules_scala into this ruleset.

The tracking issue for this effort

The relevant proposal section.

If we compiled with Zinc, we could use Zinc's analysis file to check for unused dependencies and used transitive dependencies not declared as direct dependencies. You can read the details of the proposed architecture, its pros and cons, and a comparison between it and the existing architecture here.

TL;DR is that by using Zinc for dependency checking, we can:

  • Greatly simplify this repository's dependency checking code
  • No longer have to patch the compiler to report which depedendencies were used. This should enable any compiler to be used with the ruleset, regardless of this repository's support for it
  • No longer have to rely on a compiler plugin for dependency checking
  • Move dependency checking to a worker and make it a validation action, speeding up compilation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant