diff --git a/.bazelci/presubmit.yml b/.bazelci/presubmit.yml index 7556ffcb6..227119b03 100644 --- a/.bazelci/presubmit.yml +++ b/.bazelci/presubmit.yml @@ -36,6 +36,7 @@ tasks: shell_commands: # Install xmllint - sudo apt update && sudo apt install --reinstall libxml2-utils -y + - echo "build --enable_workspace" >> .bazelrc - "./test_rules_scala.sh || buildkite-agent annotate --style 'warning' \"Optional build with latest Bazel version failed, [see here](${BUILDKITE_BUILD_URL}#${BUILDKITE_JOB_ID}) (It is not mandatory but worth checking)\"" test_rules_scala_macos: name: "./test_rules_scala" @@ -47,16 +48,16 @@ tasks: platform: windows shell_commands: - "bash test_rules_scala.sh" - test_coverage_linux_6_3_0: + test_coverage_linux_6_5_0: name: "./test_coverage" platform: ubuntu2004 - bazel: 6.3.0 + bazel: 6.5.0 shell_commands: - "./test_coverage.sh" - test_coverage_macos_6.3.0: + test_coverage_macos_6.5.0: name: "./test_coverage" platform: macos - bazel: 6.3.0 + bazel: 6.5.0 shell_commands: - "./test_coverage.sh" test_reproducibility_linux: @@ -82,13 +83,13 @@ tasks: examples_linux: name: "./test_examples" platform: ubuntu2004 - bazel: 6.3.0 + bazel: 6.5.0 shell_commands: - "./test_examples.sh" cross_build_linux: name: "./test_cross_build" platform: ubuntu2004 - bazel: 6.3.0 + bazel: 6.5.0 shell_commands: - "./test_cross_build.sh" lint_linux: diff --git a/.bazelrc b/.bazelrc index b37b4dc55..498871943 100644 --- a/.bazelrc +++ b/.bazelrc @@ -3,3 +3,7 @@ build --enable_platform_specific_config #Windows needs --worker_quit_after_build due to workers not being shut down when the compiler tools need to be rebuilt (resulting in 'file in use' errors). See Bazel Issue#10498. build:windows --worker_quit_after_build --enable_runfiles + +# Remove upon completing Bzlmod compatibility work. +# - https://github.com/bazelbuild/rules_scala/issues/1482 +build --noenable_bzlmod diff --git a/.bazelversion b/.bazelversion index 798e38995..f22d756da 100644 --- a/.bazelversion +++ b/.bazelversion @@ -1 +1 @@ -6.3.0 +6.5.0 diff --git a/WORKSPACE b/WORKSPACE index 44de58fe5..08eb52097 100644 --- a/WORKSPACE +++ b/WORKSPACE @@ -15,6 +15,17 @@ load("@bazel_skylib//:workspace.bzl", "bazel_skylib_workspace") bazel_skylib_workspace() +http_archive( + name = "rules_python", + sha256 = "ca77768989a7f311186a29747e3e95c936a41dffac779aff6b443db22290d913", + strip_prefix = "rules_python-0.36.0", + url = "https://github.com/bazelbuild/rules_python/releases/download/0.36.0/rules_python-0.36.0.tar.gz", +) + +load("@rules_python//python:repositories.bzl", "py_repositories") + +py_repositories() + _build_tools_release = "5.1.0" http_archive( @@ -127,10 +138,10 @@ format_repositories() http_archive( name = "io_bazel_rules_go", - sha256 = "dd926a88a564a9246713a9c00b35315f54cbd46b31a26d5d8fb264c07045f05d", + sha256 = "6dc2da7ab4cf5d7bfc7c949776b1b7c733f05e56edc4bcd9022bb249d2e2a996", urls = [ - "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.38.1/rules_go-v0.38.1.zip", - "https://github.com/bazelbuild/rules_go/releases/download/v0.38.1/rules_go-v0.38.1.zip", + "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.39.1/rules_go-v0.39.1.zip", + "https://github.com/bazelbuild/rules_go/releases/download/v0.39.1/rules_go-v0.39.1.zip", ], ) @@ -144,19 +155,6 @@ go_rules_dependencies() go_register_toolchains(version = "1.19.5") -# Explicitly pull in a different (newer) version of rules_java for remote jdks -rules_java_extra_version = "5.1.0" - -rules_java_extra_sha = "d974a2d6e1a534856d1b60ad6a15e57f3970d8596fbb0bb17b9ee26ca209332a" - -rules_java_extra_url = "https://github.com/bazelbuild/rules_java/releases/download/{}/rules_java-{}.tar.gz".format(rules_java_extra_version, rules_java_extra_version) - -http_archive( - name = "rules_java_extra", - sha256 = rules_java_extra_sha, - url = rules_java_extra_url, -) - load("@rules_java//java:repositories.bzl", "remote_jdk8_repos") # We need to select based on platform when we use these diff --git a/dt_patches/test_dt_patches/WORKSPACE b/dt_patches/test_dt_patches/WORKSPACE index f4bf9680c..01ddd7181 100644 --- a/dt_patches/test_dt_patches/WORKSPACE +++ b/dt_patches/test_dt_patches/WORKSPACE @@ -11,6 +11,17 @@ http_archive( ], ) +http_archive( + name = "rules_python", + sha256 = "ca77768989a7f311186a29747e3e95c936a41dffac779aff6b443db22290d913", + strip_prefix = "rules_python-0.36.0", + url = "https://github.com/bazelbuild/rules_python/releases/download/0.36.0/rules_python-0.36.0.tar.gz", +) + +load("@rules_python//python:repositories.bzl", "py_repositories") + +py_repositories() + local_repository( name = "io_bazel_rules_scala", path = "../..", diff --git a/dt_patches/test_dt_patches_user_srcjar/WORKSPACE b/dt_patches/test_dt_patches_user_srcjar/WORKSPACE index 92af9eaac..3428f472f 100644 --- a/dt_patches/test_dt_patches_user_srcjar/WORKSPACE +++ b/dt_patches/test_dt_patches_user_srcjar/WORKSPACE @@ -11,6 +11,17 @@ http_archive( ], ) +http_archive( + name = "rules_python", + sha256 = "ca77768989a7f311186a29747e3e95c936a41dffac779aff6b443db22290d913", + strip_prefix = "rules_python-0.36.0", + url = "https://github.com/bazelbuild/rules_python/releases/download/0.36.0/rules_python-0.36.0.tar.gz", +) + +load("@rules_python//python:repositories.bzl", "py_repositories") + +py_repositories() + local_repository( name = "io_bazel_rules_scala", path = "../..", diff --git a/examples/crossbuild/.bazelrc b/examples/crossbuild/.bazelrc new file mode 100644 index 000000000..100128b44 --- /dev/null +++ b/examples/crossbuild/.bazelrc @@ -0,0 +1,3 @@ +# Remove upon completing Bzlmod compatibility work. +# - https://github.com/bazelbuild/rules_scala/issues/1482 +build --noenable_bzlmod diff --git a/examples/crossbuild/WORKSPACE b/examples/crossbuild/WORKSPACE index 4711fc376..ff01165d1 100644 --- a/examples/crossbuild/WORKSPACE +++ b/examples/crossbuild/WORKSPACE @@ -11,6 +11,17 @@ http_archive( ], ) +http_archive( + name = "rules_python", + sha256 = "ca77768989a7f311186a29747e3e95c936a41dffac779aff6b443db22290d913", + strip_prefix = "rules_python-0.36.0", + url = "https://github.com/bazelbuild/rules_python/releases/download/0.36.0/rules_python-0.36.0.tar.gz", +) + +load("@rules_python//python:repositories.bzl", "py_repositories") + +py_repositories() + local_repository( name = "io_bazel_rules_scala", path = "../..", diff --git a/examples/scala3/.bazelrc b/examples/scala3/.bazelrc new file mode 100644 index 000000000..100128b44 --- /dev/null +++ b/examples/scala3/.bazelrc @@ -0,0 +1,3 @@ +# Remove upon completing Bzlmod compatibility work. +# - https://github.com/bazelbuild/rules_scala/issues/1482 +build --noenable_bzlmod diff --git a/examples/scala3/WORKSPACE b/examples/scala3/WORKSPACE index 07933b4b7..b1864f4ed 100644 --- a/examples/scala3/WORKSPACE +++ b/examples/scala3/WORKSPACE @@ -11,6 +11,17 @@ http_archive( ], ) +http_archive( + name = "rules_python", + sha256 = "ca77768989a7f311186a29747e3e95c936a41dffac779aff6b443db22290d913", + strip_prefix = "rules_python-0.36.0", + url = "https://github.com/bazelbuild/rules_python/releases/download/0.36.0/rules_python-0.36.0.tar.gz", +) + +load("@rules_python//python:repositories.bzl", "py_repositories") + +py_repositories() + local_repository( name = "io_bazel_rules_scala", path = "../..", diff --git a/examples/semanticdb/.bazelrc b/examples/semanticdb/.bazelrc new file mode 100644 index 000000000..100128b44 --- /dev/null +++ b/examples/semanticdb/.bazelrc @@ -0,0 +1,3 @@ +# Remove upon completing Bzlmod compatibility work. +# - https://github.com/bazelbuild/rules_scala/issues/1482 +build --noenable_bzlmod diff --git a/examples/semanticdb/WORKSPACE b/examples/semanticdb/WORKSPACE index 99b58d10b..d9324f8c1 100644 --- a/examples/semanticdb/WORKSPACE +++ b/examples/semanticdb/WORKSPACE @@ -14,6 +14,17 @@ http_archive( ], ) +http_archive( + name = "rules_python", + sha256 = "ca77768989a7f311186a29747e3e95c936a41dffac779aff6b443db22290d913", + strip_prefix = "rules_python-0.36.0", + url = "https://github.com/bazelbuild/rules_python/releases/download/0.36.0/rules_python-0.36.0.tar.gz", +) + +load("@rules_python//python:repositories.bzl", "py_repositories") + +py_repositories() + local_repository( name = "io_bazel_rules_scala", path = "../..", diff --git a/examples/testing/multi_frameworks_toolchain/.bazelrc b/examples/testing/multi_frameworks_toolchain/.bazelrc index 6cd4a6699..46e8bdec7 100644 --- a/examples/testing/multi_frameworks_toolchain/.bazelrc +++ b/examples/testing/multi_frameworks_toolchain/.bazelrc @@ -1,2 +1,6 @@ build --enable_platform_specific_config windows:build --enable_runfiles + +# Remove upon completing Bzlmod compatibility work. +# - https://github.com/bazelbuild/rules_scala/issues/1482 +build --noenable_bzlmod diff --git a/examples/testing/multi_frameworks_toolchain/WORKSPACE b/examples/testing/multi_frameworks_toolchain/WORKSPACE index ea4eb2f35..8070f0a0d 100644 --- a/examples/testing/multi_frameworks_toolchain/WORKSPACE +++ b/examples/testing/multi_frameworks_toolchain/WORKSPACE @@ -11,6 +11,17 @@ http_archive( ], ) +http_archive( + name = "rules_python", + sha256 = "ca77768989a7f311186a29747e3e95c936a41dffac779aff6b443db22290d913", + strip_prefix = "rules_python-0.36.0", + url = "https://github.com/bazelbuild/rules_python/releases/download/0.36.0/rules_python-0.36.0.tar.gz", +) + +load("@rules_python//python:repositories.bzl", "py_repositories") + +py_repositories() + local_repository( name = "io_bazel_rules_scala", path = "../../..", diff --git a/examples/testing/scalatest_repositories/.bazelrc b/examples/testing/scalatest_repositories/.bazelrc new file mode 100644 index 000000000..100128b44 --- /dev/null +++ b/examples/testing/scalatest_repositories/.bazelrc @@ -0,0 +1,3 @@ +# Remove upon completing Bzlmod compatibility work. +# - https://github.com/bazelbuild/rules_scala/issues/1482 +build --noenable_bzlmod diff --git a/examples/testing/scalatest_repositories/WORKSPACE b/examples/testing/scalatest_repositories/WORKSPACE index 546f9e00b..e5a2a0790 100644 --- a/examples/testing/scalatest_repositories/WORKSPACE +++ b/examples/testing/scalatest_repositories/WORKSPACE @@ -11,6 +11,17 @@ http_archive( ], ) +http_archive( + name = "rules_python", + sha256 = "ca77768989a7f311186a29747e3e95c936a41dffac779aff6b443db22290d913", + strip_prefix = "rules_python-0.36.0", + url = "https://github.com/bazelbuild/rules_python/releases/download/0.36.0/rules_python-0.36.0.tar.gz", +) + +load("@rules_python//python:repositories.bzl", "py_repositories") + +py_repositories() + local_repository( name = "io_bazel_rules_scala", path = "../../..", diff --git a/examples/testing/specs2_junit_repositories/.bazelrc b/examples/testing/specs2_junit_repositories/.bazelrc index 80890a133..46e8bdec7 100644 --- a/examples/testing/specs2_junit_repositories/.bazelrc +++ b/examples/testing/specs2_junit_repositories/.bazelrc @@ -1,2 +1,6 @@ build --enable_platform_specific_config -windows:build --enable_runfiles \ No newline at end of file +windows:build --enable_runfiles + +# Remove upon completing Bzlmod compatibility work. +# - https://github.com/bazelbuild/rules_scala/issues/1482 +build --noenable_bzlmod diff --git a/examples/testing/specs2_junit_repositories/WORKSPACE b/examples/testing/specs2_junit_repositories/WORKSPACE index 3d67bf00d..1a2dfb287 100644 --- a/examples/testing/specs2_junit_repositories/WORKSPACE +++ b/examples/testing/specs2_junit_repositories/WORKSPACE @@ -11,6 +11,17 @@ http_archive( ], ) +http_archive( + name = "rules_python", + sha256 = "ca77768989a7f311186a29747e3e95c936a41dffac779aff6b443db22290d913", + strip_prefix = "rules_python-0.36.0", + url = "https://github.com/bazelbuild/rules_python/releases/download/0.36.0/rules_python-0.36.0.tar.gz", +) + +load("@rules_python//python:repositories.bzl", "py_repositories") + +py_repositories() + local_repository( name = "io_bazel_rules_scala", path = "../../..", diff --git a/scala/private/macros/scala_repositories.bzl b/scala/private/macros/scala_repositories.bzl index e11f199d5..204fd5629 100644 --- a/scala/private/macros/scala_repositories.bzl +++ b/scala/private/macros/scala_repositories.bzl @@ -104,9 +104,9 @@ def rules_scala_setup(scala_compiler_srcjar = None): http_archive( name = "rules_java", urls = [ - "https://github.com/bazelbuild/rules_java/releases/download/5.4.1/rules_java-5.4.1.tar.gz", + "https://github.com/bazelbuild/rules_java/releases/download/7.9.0/rules_java-7.9.0.tar.gz", ], - sha256 = "a1f82b730b9c6395d3653032bd7e3a660f9d5ddb1099f427c1e1fe768f92e395", + sha256 = "41131de4417de70b9597e6ebd515168ed0ba843a325dc54a81b92d7af9a7b3ea", ) if not native.existing_rule("rules_proto"): diff --git a/scala/private/rules/scala_repl.bzl b/scala/private/rules/scala_repl.bzl index 6d08c8b84..49586da79 100644 --- a/scala/private/rules/scala_repl.bzl +++ b/scala/private/rules/scala_repl.bzl @@ -81,7 +81,10 @@ def make_scala_repl(*extras): common_outputs, *[extra["outputs"] for extra in extras if "outputs" in extra] ), - toolchains = ["@io_bazel_rules_scala//scala:toolchain_type"], + toolchains = [ + "@io_bazel_rules_scala//scala:toolchain_type", + "@bazel_tools//tools/jdk:toolchain_type", + ], cfg = scala_version_transition, incompatible_use_toolchain_transition = True, implementation = _scala_repl_impl, diff --git a/test/proto_cross_repo_boundary/repo.bzl b/test/proto_cross_repo_boundary/repo.bzl index 0f19c06d2..fe3fecf04 100644 --- a/test/proto_cross_repo_boundary/repo.bzl +++ b/test/proto_cross_repo_boundary/repo.bzl @@ -2,5 +2,5 @@ def proto_cross_repo_boundary_repository(): native.new_local_repository( name = "proto_cross_repo_boundary", path = "test/proto_cross_repo_boundary/repo", - build_file = "test/proto_cross_repo_boundary/repo/BUILD.repo", + build_file = "//test/proto_cross_repo_boundary:repo/BUILD.repo", ) diff --git a/test/shell/test_custom_reporter_class.sh b/test/shell/test_custom_reporter_class.sh index f0985db16..3daa04a01 100644 --- a/test/shell/test_custom_reporter_class.sh +++ b/test/shell/test_custom_reporter_class.sh @@ -22,9 +22,10 @@ test_custom_reporter_class_has_been_set() { bazel test test/scala_test:custom_reporter set +e reporter_output_dir="$(bazel info bazel-testlogs)/test/scala_test/custom_reporter/test.outputs" + chmod u+w "$reporter_output_dir" # Needed under Bazel 7 reporter_output_filepath="${reporter_output_dir}/${custom_reporter_check_file}" unzip -oq "${reporter_output_dir}/outputs.zip" -d "${reporter_output_dir}" assert_file_exists "${reporter_output_filepath}" } -$runner test_custom_reporter_class_has_been_set \ No newline at end of file +$runner test_custom_reporter_class_has_been_set diff --git a/test/shell/test_strict_dependency.sh b/test/shell/test_strict_dependency.sh index da6537815..01a0d4029 100755 --- a/test/shell/test_strict_dependency.sh +++ b/test/shell/test_strict_dependency.sh @@ -21,6 +21,9 @@ test_scala_import_expect_failure_on_missing_direct_deps_warn_mode() { dependency_target2='//test_expect_failure/scala_import:guava' test_target='test_expect_failure/scala_import:scala_import_propagates_compile_deps' + # Bazel 7 won't emit warnings if the output already exists. + rm -f "$(bazel info bazel-bin)/${test_target/://}"* + local expected_message1="buildozer 'add deps $dependency_target1' //$test_target" local expected_message2="buildozer 'add deps $dependency_target2' //$test_target" diff --git a/test_cross_build/.bazelrc b/test_cross_build/.bazelrc new file mode 100644 index 000000000..100128b44 --- /dev/null +++ b/test_cross_build/.bazelrc @@ -0,0 +1,3 @@ +# Remove upon completing Bzlmod compatibility work. +# - https://github.com/bazelbuild/rules_scala/issues/1482 +build --noenable_bzlmod diff --git a/test_cross_build/WORKSPACE b/test_cross_build/WORKSPACE index 1dc58574c..01f22da1c 100644 --- a/test_cross_build/WORKSPACE +++ b/test_cross_build/WORKSPACE @@ -11,6 +11,17 @@ http_archive( ], ) +http_archive( + name = "rules_python", + sha256 = "ca77768989a7f311186a29747e3e95c936a41dffac779aff6b443db22290d913", + strip_prefix = "rules_python-0.36.0", + url = "https://github.com/bazelbuild/rules_python/releases/download/0.36.0/rules_python-0.36.0.tar.gz", +) + +load("@rules_python//python:repositories.bzl", "py_repositories") + +py_repositories() + http_archive( name = "rules_proto", sha256 = "8e7d59a5b12b233be5652e3d29f42fba01c7cbab09f6b3a8d0a57ed6d1e9a0da", diff --git a/test_version/.bazelrc b/test_version/.bazelrc new file mode 100644 index 000000000..100128b44 --- /dev/null +++ b/test_version/.bazelrc @@ -0,0 +1,3 @@ +# Remove upon completing Bzlmod compatibility work. +# - https://github.com/bazelbuild/rules_scala/issues/1482 +build --noenable_bzlmod diff --git a/test_version/WORKSPACE.template b/test_version/WORKSPACE.template index 34c499f2f..741f349e1 100644 --- a/test_version/WORKSPACE.template +++ b/test_version/WORKSPACE.template @@ -11,6 +11,17 @@ http_archive( ], ) +http_archive( + name = "rules_python", + sha256 = "ca77768989a7f311186a29747e3e95c936a41dffac779aff6b443db22290d913", + strip_prefix = "rules_python-0.36.0", + url = "https://github.com/bazelbuild/rules_python/releases/download/0.36.0/rules_python-0.36.0.tar.gz", +) + +load("@rules_python//python:repositories.bzl", "py_repositories") + +py_repositories() + http_archive( name = "rules_proto", sha256 = "8e7d59a5b12b233be5652e3d29f42fba01c7cbab09f6b3a8d0a57ed6d1e9a0da", diff --git a/third_party/test/example_external_workspace/.bazelrc b/third_party/test/example_external_workspace/.bazelrc new file mode 100644 index 000000000..100128b44 --- /dev/null +++ b/third_party/test/example_external_workspace/.bazelrc @@ -0,0 +1,3 @@ +# Remove upon completing Bzlmod compatibility work. +# - https://github.com/bazelbuild/rules_scala/issues/1482 +build --noenable_bzlmod diff --git a/third_party/test/example_external_workspace/WORKSPACE b/third_party/test/example_external_workspace/WORKSPACE index 43ab12468..f065d65ba 100644 --- a/third_party/test/example_external_workspace/WORKSPACE +++ b/third_party/test/example_external_workspace/WORKSPACE @@ -11,6 +11,17 @@ http_archive( ], ) +http_archive( + name = "rules_python", + sha256 = "ca77768989a7f311186a29747e3e95c936a41dffac779aff6b443db22290d913", + strip_prefix = "rules_python-0.36.0", + url = "https://github.com/bazelbuild/rules_python/releases/download/0.36.0/rules_python-0.36.0.tar.gz", +) + +load("@rules_python//python:repositories.bzl", "py_repositories") + +py_repositories() + local_repository( name = "io_bazel_rules_scala", path = "../../..", diff --git a/third_party/test/proto/.bazelrc b/third_party/test/proto/.bazelrc new file mode 100644 index 000000000..100128b44 --- /dev/null +++ b/third_party/test/proto/.bazelrc @@ -0,0 +1,3 @@ +# Remove upon completing Bzlmod compatibility work. +# - https://github.com/bazelbuild/rules_scala/issues/1482 +build --noenable_bzlmod diff --git a/third_party/test/proto/WORKSPACE b/third_party/test/proto/WORKSPACE index 192e6f4ab..e3f4bc4af 100644 --- a/third_party/test/proto/WORKSPACE +++ b/third_party/test/proto/WORKSPACE @@ -11,6 +11,17 @@ http_archive( ], ) +http_archive( + name = "rules_python", + sha256 = "ca77768989a7f311186a29747e3e95c936a41dffac779aff6b443db22290d913", + strip_prefix = "rules_python-0.36.0", + url = "https://github.com/bazelbuild/rules_python/releases/download/0.36.0/rules_python-0.36.0.tar.gz", +) + +load("@rules_python//python:repositories.bzl", "py_repositories") + +py_repositories() + local_repository( name = "io_bazel_rules_scala", path = "../../../", diff --git a/thrift/thrift.bzl b/thrift/thrift.bzl index dacd1050c..350c05bed 100644 --- a/thrift/thrift.bzl +++ b/thrift/thrift.bzl @@ -178,4 +178,5 @@ thrift_library = rule( }, outputs = {"libarchive": "lib%{name}.jar"}, provides = [ThriftInfo], + toolchains = ["@bazel_tools//tools/jdk:toolchain_type"], ) diff --git a/tools/bazel.rc.buildkite b/tools/bazel.rc.buildkite index 9d784856c..5126d6eaf 100644 --- a/tools/bazel.rc.buildkite +++ b/tools/bazel.rc.buildkite @@ -1 +1,5 @@ build --strategy=Scalac=worker --strategy=ScroogeRule=worker --worker_max_instances=3 + +# Remove upon completing Bzlmod compatibility work. +# - https://github.com/bazelbuild/rules_scala/issues/1482 +build --noenable_bzlmod diff --git a/twitter_scrooge/twitter_scrooge.bzl b/twitter_scrooge/twitter_scrooge.bzl index eae327a1f..1bdef6ecd 100644 --- a/twitter_scrooge/twitter_scrooge.bzl +++ b/twitter_scrooge/twitter_scrooge.bzl @@ -443,6 +443,12 @@ common_aspect_providers = [ [ScroogeImport], ] +common_toolchains = [ + "@io_bazel_rules_scala//scala:toolchain_type", + "@io_bazel_rules_scala//twitter_scrooge/toolchain:scrooge_toolchain_type", + "@bazel_tools//tools/jdk:toolchain_type", +] + scrooge_scala_aspect = aspect( implementation = _scrooge_scala_aspect_impl, attr_aspects = ["deps"], @@ -459,10 +465,7 @@ scrooge_scala_aspect = aspect( ), provides = [ScroogeAspectInfo], required_aspect_providers = common_aspect_providers, - toolchains = [ - "@io_bazel_rules_scala//scala:toolchain_type", - "@io_bazel_rules_scala//twitter_scrooge/toolchain:scrooge_toolchain_type", - ], + toolchains = common_toolchains, incompatible_use_toolchain_transition = True, ) @@ -477,10 +480,7 @@ scrooge_java_aspect = aspect( ), provides = [ScroogeAspectInfo], required_aspect_providers = common_aspect_providers, - toolchains = [ - "@io_bazel_rules_scala//scala:toolchain_type", - "@io_bazel_rules_scala//twitter_scrooge/toolchain:scrooge_toolchain_type", - ], + toolchains = common_toolchains, incompatible_use_toolchain_transition = True, fragments = ["java"], ) @@ -557,6 +557,9 @@ scrooge_scala_import = rule( ), }, provides = [ThriftInfo, JavaInfo, ScroogeImport], - toolchains = ["@io_bazel_rules_scala//twitter_scrooge/toolchain:scrooge_toolchain_type"], + toolchains = [ + "@io_bazel_rules_scala//twitter_scrooge/toolchain:scrooge_toolchain_type", + "@bazel_tools//tools/jdk:toolchain_type", + ], incompatible_use_toolchain_transition = True, )