From df0fdb9526c8b4556348a8d4be2d690735ed92e3 Mon Sep 17 00:00:00 2001 From: Wassim Chegham Date: Tue, 26 Mar 2019 15:56:12 +0100 Subject: [PATCH] feat: update rules_nodejs --- WORKSPACE | 5 +++-- package.bzl | 5 +++-- sass/BUILD | 2 +- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/WORKSPACE b/WORKSPACE index ec2ee74..d92992c 100644 --- a/WORKSPACE +++ b/WORKSPACE @@ -5,8 +5,9 @@ load("//:package.bzl", "rules_sass_dependencies", "rules_sass_dev_dependencies") rules_sass_dependencies() rules_sass_dev_dependencies() -load("@build_bazel_rules_nodejs//:defs.bzl", "node_repositories") -node_repositories() +load("@build_bazel_rules_nodejs//:package.bzl", "rules_nodejs_dev_dependencies") + +rules_nodejs_dev_dependencies() load("//:defs.bzl", "sass_repositories") sass_repositories() diff --git a/package.bzl b/package.bzl index a4cdf68..356d799 100644 --- a/package.bzl +++ b/package.bzl @@ -23,11 +23,12 @@ def _include_if_not_defined(repo_rule, name, **kwargs): def rules_sass_dependencies(): # Since we use the Dart version of Sass, we need to be able to run NodeJS binaries. + # TODO(gregmagolan): update to upstream once commit below lands _include_if_not_defined( http_archive, name = "build_bazel_rules_nodejs", - url = "https://github.com/bazelbuild/rules_nodejs/releases/download/0.30.1/rules_nodejs-0.30.1.tar.gz", - sha256 = "abcf497e89cfc1d09132adfcd8c07526d026e162ae2cb681dcb896046417ce91", + urls = ["https://github.com/gregmagolan/rules_nodejs/archive/fdac52569aad207efee584b677024edf260d1c25.zip"], + strip_prefix = "rules_nodejs-fdac52569aad207efee584b677024edf260d1c25" ) # Dependencies from the NodeJS rules. We don't want to use the "package.bzl" dependency macro diff --git a/sass/BUILD b/sass/BUILD index 94aaea1..d962fd8 100644 --- a/sass/BUILD +++ b/sass/BUILD @@ -10,7 +10,7 @@ exports_files([ # Executable for the sass_binary rule nodejs_binary( name = "sass", - entry_point = "sass/sass.js", + entry_point = "@build_bazel_rules_sass_deps//node_modules/sass:sass.js", install_source_map_support = False, data = [ "@build_bazel_rules_sass_deps//sass",