From dc542c17ed08a04a1b53da877b8fe43e0251d8b8 Mon Sep 17 00:00:00 2001 From: Marcel Hlopko Date: Wed, 21 Jul 2021 09:12:57 +0200 Subject: [PATCH] Remove 2 step dance from flag removal --- COMPATIBILITY.md | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/COMPATIBILITY.md b/COMPATIBILITY.md index 4ea9592eea..6fba441a7a 100644 --- a/COMPATIBILITY.md +++ b/COMPATIBILITY.md @@ -99,11 +99,8 @@ follow cargo's behaviour are considered bug fixes. instructions/tooling. 3. Add a build setting into `//rust:incompatible.bzl` that removes the old behavior (whenever possible) or changes the current behavior (when just -removing old behavior is not possible). Users should not need to manually -flip incompatible flags. If for a specific flag they do need to manually flip -it, then in the first backwards incompatible release we make the flag be a -noop, and only in the second backwards incompatible release we remove the -flag. +removing the old behavior is not possible). Ideally, users should not need to +manually flip incompatible flags. 4. Mention the link to the GitHub issue in error messages. Do not add a deprecation warning (warnings make the deprecation visible to every user building a project, not only to the maintainers of the project or the rules).