Implement missing METADATA parsing via pkginfo

[mdvorsky]

Replaces the incomplete METADATA parsing with pkginfo. Adds tests using real-world packages.

Fixes #102

[rogerhub]

@brandjon Can you take a look? I think this patch is an important fix.

[mdvorsky]

@brandjon @lberki any thoughts at all? I realize my fix may not be the preferred way to address this, but I'd love to see this addressed one way or another, so that we can get rid of our local fork of rules_python.

[cristifalcas]

Hi @brandjon. Please let us know if this project is maintained, or we should move to something else. There are multiple PRs and issues that are not answered for months.

Importing pip packages doesn't work, using python3 is even in a worst state.

[cgordoncarroll]

Any updates on this pull request? Using Bazel in conjunction with python3/pip seems pretty painful without this. @brandjon

[ppodolsky]

I second @cgordoncarroll. Is there a way we could help to push this PR forward?

[smamessier]

Would be very interested in this being merged as well. Trying to use Bazel with Python3 deps.

[thundergolfer]

@smamessier

Have you tried any of these?

• https://github.com/dillon-giacoppo/rules_python_external
• https://github.com/soniaai/rules_poetry
• https://github.com/ali5h/rules_pip

They all support Python 3. We are using the 1st with Python 3.6 at work. It was created after bazelbuild/rules_python just wouldn't work for us.

[smamessier]

@thundergolfer Thanks I ended up using https://github.com/dillon-giacoppo/rules_python_external and it works perfectly.

[googlebot]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

[mdvorsky]

@googlebot I fixed it.

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[jakebiesinger-onduo]

👋 1-year anniversary for this PR is coming up. Any chance we could get it merged?

[mdvorsky]

/cc @thundergolfer @andyscott

[andyscott]

My only context for this code change is a close reading of the diff (unfortunately 😢 ), but with that in mind, this looks good to me.

[mdvorsky]

Thanks a lot @andyscott! Would you like me to do anything else here? (The build of your merge failed because of an unrelated issue already fixed at head, afaict).

[googlebot]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[mdvorsky]

Hi! @thundergolfer @andyscott I removed the .par files from the PR, and squashed the commits. Is there anything else I should do here? Thank you!

[horkyada]

Hi rules_python folks. Is there any chance this gets merged?

[github-actions]

This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days.
Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_python!

[xhuoroku]

@mdvorsky Thank you for the great work!

Is it possible to also make the code change for pip_import so that issue 102 can be fixed when using pip_import?

It's the only packaging rule that supports Python 2, would be super helpful if it can be fixed.