You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
builts a zip file using an instance of every supported feature
unzips that file and inspects the file system for the expected results
Doing this with maximum fidelity requires, at a minimum, using the unzip tool which would be the logical default on any given OS. If there are multiple competitors, we would need to test against several versions. So, a robust integration test would require an "unzip" toolchain that finds the right unzip tool for each OS.
OTOH, doing this completely is a lot of work for little payoff. We currently have tests that use python zipfile to inspect .zip files to see if their content is as expected. The python code base has more testing resources thrown at it than we ever will. I expect it has closer fidelity to the expected behavior on any OS than we could ever achieve. I'm happy to go with the presumption that if the python zipfile module tells us we will get a file with specific attributes, so will the OS local 'unzip'.
The text was updated successfully, but these errors were encountered:
aiuto
added
the
p4
An idea that we are not considering working on at this time.
label
Dec 26, 2021
Another thing to note here is that what python supports in its zipfile framework is not necessarily what is supported by local unzip binaries. In particular, there are alternate compression modes that may not be supported by the standard unzip tool and file format.
pkg_zip should have an intergration test that
Doing this with maximum fidelity requires, at a minimum, using the unzip tool which would be the logical default on any given OS. If there are multiple competitors, we would need to test against several versions. So, a robust integration test would require an "unzip" toolchain that finds the right unzip tool for each OS.
OTOH, doing this completely is a lot of work for little payoff. We currently have tests that use python zipfile to inspect .zip files to see if their content is as expected. The python code base has more testing resources thrown at it than we ever will. I expect it has closer fidelity to the expected behavior on any OS than we could ever achieve. I'm happy to go with the presumption that if the python zipfile module tells us we will get a file with specific attributes, so will the OS local 'unzip'.
The text was updated successfully, but these errors were encountered: