fix: sharded test never fail when using Jasmine < 4 #3360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
requested review from
mattem,
gregmagolan and
alexeagle
as code owners
alan-agius4
force-pushed
the
sharded-test-3
branch
from
5fba7ec to
5f36040
Compare
alexeagle
reviewed
Mar 10, 2022
| if (/^3\.[1-9]\.|^2\./.test(jrunner.coreVersion())) { | ||
| console.warn(`DEPRECATED: Support for Jasmine versions prior to '3.10.x' is deprecated in '@bazel/jasmine'.`); | ||
| // Jasmine versions prior to 4.0.0 should use the old API. | ||
| if (jrunner.coreVersion().charAt(0) !== '4') { |
There was a problem hiding this comment.
Not: what happens when they release 5.0?
There was a problem hiding this comment.
Can we use a peerDep as an additional warning at install time?
There was a problem hiding this comment.
When version 5 is release, the new API will be used. Currently the peer dependencies are too permissive
Maybe we should change them to:
>=2.99.0 <5
If we change however the peerDeps to ^4.0.0, this can be considered as a breaking chance since with NPM 7 this will cause the installation to fail when there are unmatched peer deps
alexeagle
approved these changes
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: angular/dev-infra#463