feat(concatjs): enable junit report for karma_web_test #2630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyubisation
requested review from
alan-agius4,
alexeagle,
gregmagolan,
mattem,
mrmeku and
soldair
as code owners
12 tasks
alexeagle
reviewed
Apr 25, 2021
|
Sure, I'll refactor it accordingly. |
alexeagle
reviewed
Apr 27, 2021
| @@ -4298,6 +4298,14 @@ [email protected]: | |||
| dependencies: | |||
| jasmine-core "^3.3" | |||
|
|
|||
| [email protected]: | |||
There was a problem hiding this comment.
We need at least one example that doesn't include this dependency to verify that we didn't accidentally introduce a breaking change.
My preference is to just update one of the examples/ to include the dependency so it's possible to observe the XML output from a karma test.
There was a problem hiding this comment.
I've removed the dependency from angular_view_engine and protocol_buffers and left it in web_testing and angular (since this is the one I'm primarily interested in).
There was a problem hiding this comment.
cool as long as there's a mix
This PR enables junit reports for karma_web_test, by adding karma-junit-reporter as a peer dependency and adding an appropriate configuration that works with bazel. karma-junit-reporter is now a peer dependency of @bazel/concatjs
alexeagle
approved these changes
May 4, 2021
| @@ -4298,6 +4298,14 @@ [email protected]: | |||
| dependencies: | |||
| jasmine-core "^3.3" | |||
|
|
|||
| [email protected]: | |||
There was a problem hiding this comment.
cool as long as there's a mix
|
Thanks!! |
|
No problem. Thanks for the pointers. 👍 |
twheys
pushed a commit
to twheys/rules_nodejs
that referenced
this pull request
Jan 13, 2022
…#2630) This PR enables junit reports for karma_web_test, by adding karma-junit-reporter as a peer dependency and adding an appropriate configuration that works with bazel. karma-junit-reporter is now a peer dependency of @bazel/concatjs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables junit reports for karma_web_test, by adding karma-junit-reporter as a
peer dependency and adding an appropriate configuration that works with bazel.
BREAKING CHANGE: karma-junit-reporter is now a peer dependency of @bazel/concatjs
PR Checklist
Please check if your PR fulfills the following requirements:
It's unclear to me if this is required or if this is part of base expectation
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #983
What is the new behavior?
Junit Report is created at path specified via the XML_OUTPUT_FILE environment variable.
Does this PR introduce a breaking change?
karma-junit-reporter is now a peer dependency of @bazel/concatjs. Add the
karma-junit-reporterpackage as a dev dependency to your project (yarn add karma-junit-reporter --devornpm install karma-junit-reporter --save-dev).Other information