fix(builtin): only generate a .tar pkg_npm output when requested #2428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
reviewed
Jan 28, 2021
| @@ -109,6 +118,12 @@ You can use values from the workspace status command using curly braces, for exa | |||
| See the section on stamping in the [README](stamping) | |||
| """, | |||
| ), | |||
| "tgz": attr.string( | |||
There was a problem hiding this comment.
can it be an attr.output ?
There was a problem hiding this comment.
oh wait I see, this attribute isn't actually used? this is just here to document how the macro works? smelly
There was a problem hiding this comment.
👃 Yeah, perhaps we refactor it like you suggested to be like ts_project macro, for another PR as that seems an independent change
mattem
force-pushed
the
fix/pkg_npm_tar_warn
branch
2 times, most recently
from
ef8fe21 to
9c975f5
Compare
alexeagle
reviewed
Jan 29, 2021
internal/pkg_npm/pkg_npm.bzl
Outdated
| name = "my_package", | ||
| srcs = ["package.json"], | ||
| deps = [":my_typescript_lib"], | ||
| tgz = "my_package_tgz", |
There was a problem hiding this comment.
this should be .tgz here right?
alexeagle
approved these changes
Jan 29, 2021
mattem
force-pushed
the
fix/pkg_npm_tar_warn
branch
from
9c975f5 to
0bd3269
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an optional attribute to the
pkg_npmmacro to generate the.tartarget. When set, the value is used as the filename, which must end in.tgz. If using this, thepkg_npmfiles must include a validpackage.jsonfile, otherwise npm will error.