Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup old stamping #2158

Closed
alexeagle opened this issue Aug 30, 2020 · 1 comment
Closed

Cleanup old stamping #2158

alexeagle opened this issue Aug 30, 2020 · 1 comment
Assignees
@alexeagle
Labels
cleanup Tech debt, resolving it improves our own velocity
Milestone
3.0

Comments

@alexeagle
Copy link
Collaborator

  • Delete bazel_stamp_file from rollup#config_file substitutions (should only use bazel_version_file and bazel_info_file)
  • Delete pkg_npm#replace_with_version
@alexeagle alexeagle added this to the 3.0 milestone Aug 30, 2020
@mattem mattem added the cleanup Tech debt, resolving it improves our own velocity label Sep 4, 2020
@alexeagle alexeagle self-assigned this Nov 3, 2020
alexeagle pushed a commit to alexeagle/rules_nodejs that referenced this issue Nov 25, 2020
chore: remove old stamping
268771b 
BREAKING CHANGE:
- rollup_bundle config_file no longer has substitutions from a "bazel_stamp_file" - use bazel_version_file instead
- pkg_npm no longer has replace_with_version attribute, use substitutions instead

Fixes bazel-contrib#2158
@alexeagle alexeagle mentioned this issue Nov 25, 2020
Merged
alexeagle pushed a commit to alexeagle/rules_nodejs that referenced this issue Nov 25, 2020
chore: remove old stamping
ff65999 
BREAKING CHANGE:
- rollup_bundle config_file no longer has substitutions from a "bazel_stamp_file" - use bazel_version_file instead
- pkg_npm no longer has replace_with_version attribute, use substitutions instead

Fixes bazel-contrib#2158
alexeagle pushed a commit that referenced this issue Nov 25, 2020
@alexeagle
chore: remove old stamping
68b18d8 
BREAKING CHANGE:
- rollup_bundle config_file no longer has substitutions from a "bazel_stamp_file" - use bazel_version_file instead
- pkg_npm no longer has replace_with_version attribute, use substitutions instead

Fixes #2158
@alexeagle
Copy link
Collaborator Author

fixed by #2312

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexeagle alexeagle

Labels
cleanup Tech debt, resolving it improves our own velocity
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
2 participants
@alexeagle @mattem