fix(builtin): fix for nodejs_binary entry point in bazel-out logic #1739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmagolan
added a commit
to gregmagolan/rules_nodejs
that referenced
this pull request
Mar 26, 2020
gregmagolan
force-pushed
the
fix_windows_nodejs_binary_entry_point
branch
from
ed6cbe3 to
fa0b8fb
Compare
gregmagolan
changed the title
gregmagolan
force-pushed
the
fix_windows_nodejs_binary_entry_point
branch
from
fa0b8fb to
ea5058f
Compare
If entry point is a generated file in bazel-out nodejs_binary fails with ``` Error: Cannot find module '/private/var/tmp/_bazel/.../foobar.sh.runfiles/wksp/bazel-out/plat-form/bin/path/to/entry_point.js' ```
gregmagolan
force-pushed
the
fix_windows_nodejs_binary_entry_point
branch
from
ea5058f to
6899453
Compare
gregmagolan
changed the title
alexeagle
approved these changes
Mar 26, 2020
| @@ -191,7 +191,10 @@ for ARG in "${ALL_ARGS[@]:-}"; do | |||
| case "$ARG" in | |||
| --bazel_node_modules_manifest=*) MODULES_MANIFEST="${ARG#--bazel_node_modules_manifest=}" ;; | |||
| --nobazel_patch_module_resolver) | |||
| MAIN="TEMPLATED_script_path" | |||
| declare MAIN=$(rlocation "TEMPLATED_entry_point_manifest_path") | |||
There was a problem hiding this comment.
How did we never see this bug before?? We've had entry_point pointing to bazel-out for a while haven't we? or is this the first time we are trying to do that without the patched module resolver?
There was a problem hiding this comment.
I know. I was surprised as well. We always had main.ts as the entry point of which was renamed to main.js by the rule & the parched resolver always found it.
alexeagle
added a commit
to jbedard/rules_nodejs
that referenced
this pull request
Mar 27, 2020
…logic (bazel-contrib#1739)" This reverts commit a6e29c2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-factor out of #1715
If entry point is a generated file in bazel-out nodejs_binary fails with