Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: logic error in expand_variables #1631

Merged

Conversation

gregmagolan
Copy link
Collaborator

@gregmagolan gregmagolan commented Feb 12, 2020

A little pre-factor for when expand_variables is used in other rules where there are no outs.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@googlebot
Copy link

☹️ Sorry, but only Googlers may change the label cla: yes.

@googlebot
Copy link

☹️ Sorry, but only Googlers may change the label cla: yes.

@gregmagolan gregmagolan force-pushed the fix_expand_variables_logic branch from d7058dd to 5beac84 Compare February 12, 2020 00:34
@gregmagolan gregmagolan merged commit 32c003f into bazel-contrib:master Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants