Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont generate build files in symlinked node_modules #1111

Merged
merged 2 commits into from
Oct 9, 2019

Conversation

soldair
Copy link
Collaborator

@soldair soldair commented Sep 9, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

when local packages already managed with build files are linked into node_modules they may be erroneously re-exported causing directory has a BUILD file failures.

this should be a fix for #871

What is the new behavior?

when searching for packages under a given path if one is a symlink it'll be skipped.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Collaborator

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note from in-person discussion: we tested this manually, and it solves our immediate problem.

we need better testing for this which we'll add as we port it to typescript

@alexeagle
Copy link
Collaborator

what happened with this one? I'm still getting all the BUILD.bazel files renamed in the project after testing in windows-mode

@soldair soldair force-pushed the create-build-files-filter-links branch from add3e1b to cdc9237 Compare October 8, 2019 16:49
@alexeagle alexeagle merged commit 2e7de34 into master Oct 9, 2019
@mattem mattem deleted the create-build-files-filter-links branch April 10, 2021 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants