fix: node executables not running on windows if bash toolchain path contains whitespace #1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
contains whitespace. The windows launcher code does currently break if the path to the bash binary contains a whitespace. This is common on windows where programs are stored under `C:\Program Files`. e.g. ``` :run C:/Program Files/msys2/usr/bin/bash.exe -c "!run_script!" ``` The path needs to be quoted so that it won't be incorrectly picked up as two separate commands. Resulting in an exception like: ``` 'C:/Program' is not recognized as an internal or external command, operable program or batch file. ```
devversion
requested review from
alexeagle,
gregmagolan and
soldair
as code owners
alexeagle
approved these changes
Sep 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The windows launcher code does currently break if the path to the bash
binary contains a whitespace.
This is common on windows where programs are stored under
C:\Program Files.e.g.
The path needs to be quoted so that it won't be incorrectly picked up as
two separate commands. Resulting in an
exception like: