Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename/move ts_devserver #1082

Closed
pauldraper opened this issue Sep 2, 2019 · 3 comments
Closed

Rename/move ts_devserver #1082

pauldraper opened this issue Sep 2, 2019 · 3 comments
Milestone

Comments

@pauldraper
Copy link

🚀 feature request

Nit, but "ts_devserver" is a rather misleading name, as it doesn't touch TypeScript at all. Ideally, it'd be named something like js_devserver.

Also, funnily enough, it's in rules_typescript. (I suspect this simply the world being exposed to some internal Google organizational concern?)

@alexeagle
Copy link
Collaborator

You caught our organizational concern!

if I were to name this today, I'd call it concatjs_devserver since it's tied to that particular bundler (and requires named AMD/UMD inputs or goog.module which is unusual)

We are thinking of some renames internally too. Googlers: http://b/140889721

@alexeagle alexeagle added this to the 3.0 milestone Aug 16, 2020
@alexeagle
Copy link
Collaborator

Let's rename to named_amd_devserver or concatjs_devserver since it's restricted to JS modules whose paths can be lost

alexeagle pushed a commit to alexeagle/rules_nodejs that referenced this issue Oct 18, 2020
…l/concatjs

BREAKING CHANGE:
users need to change their load statements for ts_devserver

Fixes bazel-contrib#1082
alexeagle pushed a commit to alexeagle/rules_nodejs that referenced this issue Oct 18, 2020
…l/concatjs

BREAKING CHANGE:
users need to change their load statements for ts_devserver

Fixes bazel-contrib#1082
alexeagle pushed a commit to alexeagle/rules_nodejs that referenced this issue Oct 18, 2020
…l/concatjs

BREAKING CHANGE:
users need to change their load statements for ts_devserver

Fixes bazel-contrib#1082
alexeagle pushed a commit to alexeagle/rules_nodejs that referenced this issue Oct 19, 2020
…ncatjs

BREAKING CHANGE:
users need to change their load statements for ts_devserver

Fixes bazel-contrib#1082
alexeagle pushed a commit that referenced this issue Oct 20, 2020
…ncatjs

BREAKING CHANGE:
users need to change their load statements for ts_devserver

Fixes #1082
@alexeagle
Copy link
Collaborator

landed in #2239

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants