Skip to content

Commit

Permalink
fix(builtin): only pass kwargs to the test, not the .update binary (#…
Browse files Browse the repository at this point in the history
…2361)

This allows you to set things like size or timeout to prevent warnings under bazel test --test_verbose_timeout_warnings
  • Loading branch information
alexeagle authored Dec 22, 2020
1 parent 2a9abfc commit afa095b
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions internal/generated_file_test/generated_file_test.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ def generated_file_test(name, generated, src, substring_search = False, src_dbg
anywhere within the generated file. Note that the .update rule is not generated in substring mode.
src_dbg: if the build uses `--compilation_mode dbg` then some rules will produce different output.
In this case you can specify what the dbg version of the output should look like
**kwargs: extra arguments passed to the underlying nodejs_test or nodejs_binary
**kwargs: extra arguments passed to the underlying nodejs_test
"""
data = [src, generated]

Expand Down Expand Up @@ -46,5 +46,4 @@ def generated_file_test(name, generated, src, substring_search = False, src_dbg
entry_point = "@build_bazel_rules_nodejs//internal/generated_file_test:bundle.js",
templated_args = ["--out", loc % src, loc % src_dbg, loc % generated],
data = data,
**kwargs
)

0 comments on commit afa095b

Please sign in to comment.