fix(jasmine): sharded test never fail when using Jasmine < 4 (#3360)

See: angular/dev-infra#463
bazel-contrib · Mar 11, 2022 · add1452 · add1452
1 parent 8606c50
commit add1452
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/e2e/BUILD.bazel b/e2e/BUILD.bazel
@@ -70,9 +70,9 @@ e2e_integration_test(
     # Old API
     "2.99.x",
     "3.9.x",
+    "3.10.x",
     # New API
     "4.0.x",
-    "3.10.x",
 ]]
 
 e2e_integration_test(

diff --git a/packages/jasmine/jasmine_runner.js b/packages/jasmine/jasmine_runner.js
@@ -146,9 +146,9 @@ async function main(args) {
 
   // TODO(6.0): remove support for deprecated versions of Jasmine that use the old API &
   // remember to update the `peerDependencies` as well.
-  // Jasmine versions prior to 3.10.0 should use the old API.
-  if (/^3\.[1-9]\.|^2\./.test(jrunner.coreVersion())) {
-    console.warn(`DEPRECATED: Support for Jasmine versions prior to '3.10.x' is deprecated in '@bazel/jasmine'.`);
+  // Jasmine versions prior to 4.0.0 should use the old API.
+  if (jrunner.coreVersion().charAt(0) !== '4') {
+    console.warn(`DEPRECATED: Support for Jasmine versions prior to '4.0.x' is deprecated in '@bazel/jasmine'.`);
 
     // Old Jasmine API.
     let noSpecsFound = true;