feat(terser): add args attribute to support additional command line…

… arguments

Terser only parses minify() args from the config_file so additional arguments such as --comments may
be passed to the rule this attribute. See https://github.com/terser/terser#command-line-usage for a list
of terser CLI options.

packages/terser/src/terser_minified.bzl

@@ -43,6 +43,13 @@ If you want to do this, you can pass a filegroup here.""",
         allow_files = [".js", ".map", ".mjs"],
         mandatory = True,
     ),
+    "args": attr.string_list(
+        doc = """Additional command line arguments to pass to terser.
+
+Terser only parses minify() args from the config file so additional arguments such as `--comments` may
+be passed to the rule using this attribute. See https://github.com/terser/terser#command-line-usage for the
+full list of terser CLI options.""",
+    ),
     "config_file": attr.label(
         doc = """A JSON file containing Terser minify() options.
 
@@ -156,6 +163,7 @@ def _terser(ctx):
     )
 
     args.add_all(["--config-file", opts.path])
+    args.add_all(ctx.attr.args)
 
     ctx.actions.run(
         inputs = inputs,

packages/terser/test/args/BUILD.bazel

@@ -0,0 +1,16 @@
+load("@build_bazel_rules_nodejs//internal/golden_file_test:golden_file_test.bzl", "golden_file_test")
+load("@npm_bazel_terser//:index.from_src.bzl", "terser_minified")
+
+terser_minified(
+    name = "out.min",
+    src = "input.js",
+    args = ["--comments"],
+    sourcemap = False,
+)
+
+golden_file_test(
+    name = "test",
+    actual = "out.min",
+    golden = "output.golden.js_",
+    golden_debug = "output.debug.golden.js_",
+)

packages/terser/test/args/input.js

@@ -0,0 +1,12 @@
+/**
+ * @license
+ * Copyright Google Inc. All Rights Reserved.
+ *
+ * Use of this source code is governed by an MIT-style license that can be
+ * found in the LICENSE file at https://angular.io/license
+ */
+class A {
+  doThing() {
+    console.error('thing');
+  }
+}

packages/terser/test/args/output.debug.golden.js_

@@ -0,0 +1,12 @@
+/**
+ * @license
+ * Copyright Google Inc. All Rights Reserved.
+ *
+ * Use of this source code is governed by an MIT-style license that can be
+ * found in the LICENSE file at https://angular.io/license
+ */
+class A {
+    doThing() {
+        console.error("thing");
+    }
+}

packages/terser/test/args/output.golden.js_

@@ -0,0 +1,8 @@
+/**
+ * @license
+ * Copyright Google Inc. All Rights Reserved.
+ *
+ * Use of this source code is governed by an MIT-style license that can be
+ * found in the LICENSE file at https://angular.io/license
+ */
+class A{doThing(){console.error("thing")}}